kit icon indicating copy to clipboard operation
kit copied to clipboard

feat: add HTTPS and HTTP/2 support for `adapter-node`

Open aradalvand opened this issue 2 years ago • 6 comments

Closes #1451 Closes #2190

~~More of a proof of concept right now~~, just want to know if we're on the same page regarding the approach here, before I add tests and so on. Let me know your thoughts.

There is a type error when trying to pass app.handler to the http*.createServer methods, which I've filed an issue for in the Polka repo here. It does actually work though, Polka's typing just seems to be slightly off.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

aradalvand avatar Jun 18 '23 15:06 aradalvand

This is still reproducible in 2.22

pantharshit00 avatar May 04 '21 14:05 pantharshit00

User report of this issue: https://github.com/prisma/prisma/issues/8746#issuecomment-904542665

pantharshit00 avatar Aug 24 '21 11:08 pantharshit00

Facing the same issue with MySQL after changing the value of my @id to autoincrement. image

Prisma migrate fails as well: image

CompeyDev avatar Jul 30 '22 05:07 CompeyDev

Hi @CompeyDev , this is a different issue — the database error says the user you log in on mysql as can't create databases. The solution to this is in general to create another empty mysql, and use the shadowDatabaseUrl property in your datasource. Here's a link to the relevant docs: https://www.prisma.io/docs/concepts/components/prisma-migrate/shadow-database

tomhoule avatar Aug 01 '22 05:08 tomhoule

Yeah, I'm actually hosting the database on PlanetScale, so I suppose that's the reason this is happening. This is one of many issues that occurs with Prisma x PlanetScale.

CompeyDev avatar Aug 01 '22 11:08 CompeyDev

Temporarily, I switched from Int to String, and it works properly though.

CompeyDev avatar Aug 01 '22 11:08 CompeyDev

On PlanetScale we usually recommend db push (in that case, no shadow database needed), because PlanetScale already has its own solution to manager migrations with branches.

tomhoule avatar Aug 01 '22 12:08 tomhoule

Yeah, and even once that's done, I still face the issue: image

CompeyDev avatar Aug 01 '22 15:08 CompeyDev

It may have to do with vitess (what PlanetScale builds on) having trouble dealing with tables without primary key, since your migration redefines the primary keys. I'll try to get in touch with them. This is something completely different from what this issue is about (postgres SERIAL columns).

tomhoule avatar Aug 01 '22 19:08 tomhoule

Alright, fair enough. I'll not bother going into such a minute detail for the moment and if this crops up again, I'll create an issue and let you know.

CompeyDev avatar Aug 02 '22 15:08 CompeyDev

This is still an issue. Would love to see a solution 🫶

templela avatar May 30 '23 15:05 templela

Still an issue in the latest release (4.16.0)

nanodino avatar Jun 22 '23 14:06 nanodino