crispy-forms-foundation icon indicating copy to clipboard operation
crispy-forms-foundation copied to clipboard
verified publisher icon sveetch

Missing row.html and column.html templates in 0.8.0

Open mpasternak opened this issue 5 years ago • 3 comments

Hi,

this commit:

https://github.com/sveetch/crispy-forms-foundation/pull/43/commits/78759aa8e71daa90e8f2618e606761464fb7e7e8#diff-1a77a0ef39514b22b57499cd39df30c1

had both row.html and column.html and it looks like they're missing in release 0.8.0. Could you please add those files and release it to PyPI? Thanks!

mpasternak avatar Aug 08 '20 14:08 mpasternak

Yep, this is because grid column and row are already implemented through grid layout components:

https://crispy-forms-foundation.readthedocs.io/en/latest/layout/grid.html

sveetch avatar Aug 12 '20 00:08 sveetch

Silly me! Instead of importing crispy_forms_foundation.layout, I was importing from crispy_forms.layout. This gave me error about missing foundation6/layout/col.html and such.

Perhaps this bug I encountered could be documented somewhere, how do you think?

mpasternak avatar Aug 12 '20 17:08 mpasternak

I could write a warning line about this in documentation, it won't cost anything, still i don't know i will have the heart to release documentation just for this :)

I will keep this issue open to remember it for a possible next release.

sveetch avatar Aug 13 '20 20:08 sveetch