react-native-swiper2 icon indicating copy to clipboard operation
react-native-swiper2 copied to clipboard

pagination doesn't work on android

Open httnn opened this issue 9 years ago • 9 comments

first of all, thank you for this fork!

I just noticed that on Android it scrolls like a normal ScrollView without snapping to the views, have you noticed this?

here's how I use it:

<Swiper loop={false}>
...  
</Swiper>

httnn avatar Dec 15 '15 16:12 httnn

It does not support Android yet. It needs to use ViewPager instead of ScrollView on Android, which is still work in progress.

sunnylqm avatar Dec 16 '15 00:12 sunnylqm

oh so the original component didn't support android either? why can't android use ScrollView too? On Dec 16, 2015 02:38, "sunnylqm" [email protected] wrote:

It does not support Android yet. It needs to use ViewPager instead of ScrollView on Android, which is still work in progress.

— Reply to this email directly or view it on GitHub https://github.com/sunnylqm/react-native-swiper2/issues/1#issuecomment-164945973 .

httnn avatar Dec 16 '15 08:12 httnn

Because pagingEnabled prop of ScrollView is now ios only.

sunnylqm avatar Dec 16 '15 08:12 sunnylqm

ah I see. I might need to do a PR with a fix soon.

httnn avatar Dec 16 '15 08:12 httnn

PR would be great!

sunnylqm avatar Dec 17 '15 02:12 sunnylqm

actually, as I don't need any of the extra functionality (just need the paging), I think I'm going to go with a custom component for my project. would be too much work to implement all the options for android separately, but maybe I'll try that later. or would you accept a PR where on Android there would just be the paging, all other features disabled? maybe in a new branch dedicated for android support?

httnn avatar Dec 17 '15 08:12 httnn

Any progress will be accepted if it does not break current functions.

sunnylqm avatar Dec 17 '15 08:12 sunnylqm

+1 Pagination does not work properly on Android if loop is disabled / false.

shukerullah avatar Jul 13 '16 11:07 shukerullah

Why this issue is closed? Pagination is still not working properly on Android.

shukerullah avatar Aug 30 '16 15:08 shukerullah