h2spec icon indicating copy to clipboard operation
h2spec copied to clipboard

stream errors

Open kazu-yamamoto opened this issue 3 years ago • 2 comments

Sec 5.4.1 of RFC 9113 says:

In particular, an endpoint MAY choose to treat a stream error as a connection error.

But h2spec expects PING only for the three test cases for stream errors:

Failures: 

Generic tests for HTTP/2 server
  2. Streams and Multiplexing
    using source address 127.0.0.1:61348
    × 4: Sends a RST_STREAM frame on half-closed (remote) stream
      -> The endpoint MUST accept RST_STREAM frame.
         Expected: PING Frame (length:8, flags:0x01, stream_id:0, opaque_data:)
           Actual: Connection closed

  3. Frame Definitions
    3.4. RST_STREAM
      using source address 127.0.0.1:61361
      × 1: Sends a RST_STREAM frame
        -> The endpoint MUST accept RST_STREAM frame.
           Expected: PING Frame (length:8, flags:0x01, stream_id:0, opaque_data:)
             Actual: Connection closed

Hypertext Transfer Protocol Version 2 (HTTP/2)
  7. Error Codes
    using source address 127.0.0.1:61467
    × 2: Sends a RST_STREAM frame with unknown error code
      -> The endpoint MUST NOT trigger any special behavior.
         Expected: PING Frame (length:8, flags:0x01, stream_id:0, opaque_data:)
           Actual: Connection closed

I think GOAWAY is also allowed.

kazu-yamamoto avatar Jun 24 '22 01:06 kazu-yamamoto

Thank you for the report! I believe that this was fixed in 3dd93987.

summerwind avatar Jun 25 '22 13:06 summerwind

Yes. Fixed. Thanks!

kazu-yamamoto avatar Jun 26 '22 01:06 kazu-yamamoto

Maybe this issue should be closed?

KingMob avatar Sep 27 '23 08:09 KingMob

Yes!

kazu-yamamoto avatar Sep 28 '23 22:09 kazu-yamamoto