subo

subo copied to clipboard

Instead of runnables.wasm.zip, we should name the file based on the appName in Directive.yaml, i.e. [email protected]

hey @cohix

can I pick up this one?

@kurious-diru hello! even though I filed this issue, I'm not actually sure if I think it's a good idea any more :) The main reason being that currently Atmo has a single filename to look for when starting up. If we start changing the name of the file, it would make it easier to know which file relates to which application, but it would also make it trickier for Atmo to figure out where to get the file from.

Interested to hear @javorszky and @jagger27 thoughts on this.

Hm... what was the original reason why this came up? Does it matter what the file is called? Is the file used anywhere else besides internally as a transient step between a directive file and running the runnable? Does the filename appear in the logs? Would there be a situation where we'd need to tell the difference between logs from different files?

@javorszky the main thing here is knowing which version the bundle is for. If I have a runnables.wasm.zip file that was built by subo build, I have no idea which version of the application this was for.

The name of the file doesn't actually matter, it's mostly for human-readable convenience reasons.

Wouldn't you want to recompile the runnables before starting a dev server in either case? Knowing what version of the appliaction (I assume... reactr?) the wasm zip was build for is nice, but is that useful to know? What decisions does that inform?