Android 2.3 Native (Webkit) not working?

Hi there! Lots of promise to this, but it didn't seem to work. I noticed two things:

1. There was no 500ms delay, which hinted to me that something may have gone awry right from the get-go
2. Did not work on Android. When tapping the menu item containing a dropdown, It would just load whatever that link was. In your live demo, I thought it was odd that the page jumped to the top (the behaviour for an empty "#"), but I took it a step further: I fired up the included demo and changed the "#" to a real URL; sure enough, that's where I was sent.

As far as I can tell, it's not doing anything at all except maybe some JavaScript "visibility: hidden" stuff that doesn't enable the drop-down for Android mobile.

Thanks for pointing this out, greg, but I think you're looking for a feature that make_dropdown currently doesn't have.

Let me know if this isn't the case, but the behavior you want is for dropdown menu "headers" to link to other pages on click on non-mobile, but automatically not link to other pages when tapped, and instead display the dropdown menu on mobile, correct?

It currently doesn't do that, so currently you'll just have to ensure your dropdown headers don't actually link anywhere. It isn't the first time I've been asked to support this though, so I really should find time to try to implement it. If you could send a pull request over that'd be even better!

Oh, I see! Yes, you are correct; the headers do indeed have links to other pages.

I have never made a pull request on Github before, but if I get it figured out, I may just do that!

Greg

On 14.05.2012 12:32, suan wrote:

Thanks for pointing this out, greg, but I think you're looking for a feature that make_dropdown currently doesn't have.

Let me know if this isn't the case, but the behavior you want is for dropdown menu "headers" to link to other pages on click on non-mobile, but automatically not link to other pages when tapped, and instead display the dropdown menu on mobile, correct?

It currently doesn't do that, so currently you'll just have to ensure your dropdown headers don't actually link anywhere. It isn't the first time I've been asked to support this though, so I really should find time to try to implement it. If you could send a pull request over that'd be even better!

---

Reply to this email directly or view it on GitHub:

https://github.com/suan/make_dropdown/issues/1#issuecomment-5694889 [1]

Links:

[1] https://github.com/suan/make_dropdown/issues/1#issuecomment-5694889