broken-link-checker icon indicating copy to clipboard operation
broken-link-checker copied to clipboard

Published 20 hours ago • verified publisher icon stevenvachon

No ECONNREFUSED catch when honorRobotExclusions === true

Open Zauberbutter opened this issue 7 years ago • 3 comments

https://github.com/stevenvachon/broken-link-checker/blob/master/lib/public/SiteChecker.js#L48

Why is this commented out?

Zauberbutter avatar Feb 11 '18 12:02 Zauberbutter

Because the error isn't used. It simply moves onto the next page.

stevenvachon avatar Feb 11 '18 15:02 stevenvachon

Nope not when the first page isn't reachable, then it throws a uncaught error. Because it tries to grep the Robot file, when honorRobotExclusions = true.

I think in v0.8.0 this is fixed btw.

Zauberbutter avatar Feb 11 '18 15:02 Zauberbutter

I'm only merging PRs to master branch right now. All other work is being done in v0.8.0

I haven't worked on this in a while, though. Looking to return to it in the spring.

stevenvachon avatar Feb 11 '18 15:02 stevenvachon