Steven Roose

Just some thing relevant on this, I changed the locales in those not-dropdowns and it broke the db. I had to wipe and restart. Somehow it broke the ID index...

Perfect, thanks!

Maybe a cool view would be like a calendar view (you know like 7 columns, one for each weekday, and then scrolling through time. And then either show each day...

Where did you get the 77 from?

In the BIP, I describe prefixing the challenge with `Proof-of-Reserves:` as well. Didn't implement it yet, I have a refactor branch with updates from the BIP after review.

As for message vs challenge, that would change a bit of naming in the BIP. I see the point, though.

> @[sanket1729](https://github.com/sanket1729) sanket1729 changed the title ~Comment out Wasm build on CI~ Musig2 support [Mar 21, 2022](https://github.com/BlockstreamResearch/rust-secp256k1-zkp/pull/48#event-6278612901) Well that escalated quickly.. I'm super excited about this though, guys!

Not actively reviewing, but trying to use this. The `new_musig_nonce_pair` function has this sentence in the documentation that is not correct english and confuses me: > If you cannot provide...

Are you planning serde serialization for the types?

Suggestion: change the `MusigKeyAggCache` pubkey argument to an iterator so that the user doesn't necessarily have to allocate. ```rust pub fn new(secp: &Secp256k1, pubkeys: &[PublicKey]) -> Self { ``` EDIT:...