Steven Roose
Steven Roose
Yeah my only concern with `'bf` is that it might be ambiguous since there is the `&[u8]` that is used as input, but for the buffered logic, there is also...
I just noticed that `read_event_unbuffered` exists, but it's not documented on docs.rs. Also, the `read_event` default forwards to the buffered version. I'm kind of thinking this default is a bit...
I'd say a standard interface for different node types would make sense. Then you can have 2 or more different impls.
Just rebased this, can this get another chance?
Jus a heads-up that I'm still having this regularly. My server is ejabberd.
I want to mention that I appreciate this thoughtful discussion taking MSRV seriously.
Yeah I think since it's already the user that provides the fields, it should be up to the user to decide whether to set the `non_witness_utxo` field. If the user...
But fwiw, I couldn't even find the code that was requiring it. There is this check in `add_foreign_utxo` about the prevout fields, but it doesn't get generated there, so it...
I still think it's not ideal that bdk enforces this. In an application where the field is not required, it can be pretty annoying to get his value.. Currently I...
PR would be very welcome. I can't see immediately what is going on, but I've been away from Dart for quite a while now..