precedent icon indicating copy to clipboard operation
precedent copied to clipboard

Added Twitter auth

Open yasinkavakliat opened this issue 2 years ago • 3 comments

This PR adds Twitter authentication to NextAuth. Additionally it fixes an issue with Twitter OAuth 2.0 which doesn't return the users email address and can cause issues in the user-dropdown.tsx component because otherwise it'd return null.

yasinkavakliat avatar Jan 14 '23 10:01 yasinkavakliat

Someone is attempting to deploy a commit to the Elegance Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 14 '23 10:01 vercel[bot]

Great addition! The only concern I have here is there will be an extra step for folks who wanna clone and deploy this without editing the code locally. Is there a way we can check if the TWITTER_CLIENT_ID and TWITTER_CLIENT_SECRET variables are defined, if so, then we show the Twitter login button; if not, we hide it?

steven-tey avatar Jan 15 '23 01:01 steven-tey

Great addition! The only concern I have here is there will be an extra step for folks who wanna clone and deploy this without editing the code locally. Is there a way we can check if the TWITTER_CLIENT_ID and TWITTER_CLIENT_SECRET variables are defined, if so, then we show the Twitter login button; if not, we hide it?

I think this can be handled through next-auth list of enabled providers

agustif avatar Feb 05 '23 22:02 agustif