swift-log-telegram icon indicating copy to clipboard operation
swift-log-telegram copied to clipboard

Published 20 hours ago • verified publisher icon stevapple

Fix log message

Open yehorchernenko opened this issue 2 years ago • 4 comments

Fix the case when request is refused because metadata has unsupported symbols

yehorchernenko avatar May 22 '23 08:05 yehorchernenko

@stevapple Please take a look 🙏

yehorchernenko avatar May 22 '23 08:05 yehorchernenko

Thanks for fixing this and helping with Swift Concurrency migration! @yehorchernenko

For using Task and async/await we'd better bump the minimum Swift requirement to 5.5 first. The implementation itself looks good and I'm going to merge once I can confirm it's compatible with both Linux and macOS. Hopefully a basic CI pipeline could be set up soon.

stevapple avatar May 22 '23 09:05 stevapple

Hi @stevapple :)

I'm implementing this package on my project and after some hours of debugging I came with the same fix that Yehor is proposing (escaping the metadata) image

It would be great if this could be merged ❤️

dev-onepayclick avatar Jul 03 '23 16:07 dev-onepayclick

Hi @dev-onepayclick! Thanks for your reply. I would be glad to apply the fix, but I think this PR is adding too many stuffs other than the fix now. Some of them (namely bumping Swift and platform version requirements) are unnecessary for the fix, and still needs careful design.

@yehorchernenko Would you mind splitting all unrelated changes into a separate PR, making this a simple, 1-line change?

stevapple avatar Jul 03 '23 16:07 stevapple