Stephen Celis
Stephen Celis
Hi @laviallb! Thanks for taking the time to PR! We have a few questions because we want to better understand what you're solving for. > The idea behind that is...
@laviallb Sorry, just circling around to this now. Brandon and I will try to chat about it tomorrow. It's definitely an interesting idea and we're starting to see the churn...
@tahirmt Thanks for these general explorations! Sorry to push back again on added protocol surface area, but we already think the 3 this repo ships with is a lot 😄...
@rcarver We had a few ideas but this was the least invasive one that seems to work: https://github.com/pointfreeco/swift-composable-architecture/compare/weak-tasks Not quite sure it's the right "fix" though. First, while it seems...
I filed FB11690443 ("Concurrency instrument shows task as 'alive' even when finished") if anyone wants to dupe.
@rcarver Since it appears this isn't really a "leak" (the tasks are only retained as long as the parent is alive), and since my "fix" doesn't really do anything except...
@rcarver Let us know if it does! Task handles should be super lightweight, though, just 8 bytes per task in this array, so I imagine you'd have to be accumulating...
For what it's worth I think it'll still accumulate "weak tasks" 😉
@rcarver I'm going to move this to a discussion for now. While there are potential improvements we could maybe make, it's hard to measure the problem right now. Please do...
> This sets in stone no evolution to add support of failure cases in reducers (which is the current direction anyhow 😕). Is TCA going to use the `Effect` type...