grpc-rust consider building tokio-tls and openssl optionally

consider building tokio-tls and openssl optionally

Open siddontang opened this issue 8 years ago • 5 comments

@stepancheg

I see that now grpc imports tokio-tls and openssl but doesn't use it anywhere. Users should install openssl to build even they don't want to use TLS.

Maybe we can use a optional feature to control it.

Mar 30 '17 01:03 siddontang

I agree.

Mar 30 '17 04:03 stepancheg

/cc @overvenus

Maybe we can send a PR later.

Apr 01 '17 02:04 siddontang

I would recommend that if TLS is made optional, the default should be to have it operational. We should encourage the use of TLS.

Apr 27 '17 13:04 rschulman

Probably better option would be making TLS implementation optional in native-tls crate. I've created a feature-request.

May 02 '17 02:05 stepancheg

Looks like that issue was closed unfortunately :(

Apr 24 '18 04:04 eberkund