stefanprobst
stefanprobst
thanks, that's helpful! the "menu button" section has a ["Navigation Menu Button"](https://www.w3.org/TR/wai-aria-practices/#examples-8) example, which is what i'm trying to do.
> In order to support something like this, we'd need to support an elementType much like we do with Button is this something that you're planning to support in the...
to make this work with links as menu items, i had to still do the actual navigation programmatically with `router.push` in `onAction`, because (as far as i can tell) `state.isOpen`...
hi, thanks for your time with this! * your codesandbox does indeed work, but it breaks when adding `onClose` to `useMenuItem` (see https://codesandbox.io/s/hopeful-joliot-jm9ge): ```diff let { menuItemProps } = useMenuItem(...
see https://codesandbox.io/s/pedantic-brook-iuyph?file=/src/App.js client-side transitions in this CRA+react-router example work when `closeOnSelect: false` - but then the menu stays open after nav. when setting `closeOnSelect: true`, no navigation happens.
thanks! i've gone with the `onAction` option, which also allows mixing link and non-link menuitems. in case anyone want to use option 2 with next.js, closing on [`routeChangeStart`](https://nextjs.org/docs/api-reference/next/router#routerevents) event works...
hi, echoing the above - i think it would be good to mention in the docs somewhere that currently there are issues with `StrictMode` (running into https://github.com/adobe/react-spectrum/issues/977 myself).
i think the issue is that `@codemirror/basic-setup` is deprecated (and still depending on the v0.20 packages) and has been renamed to just `codemirror`. see https://discuss.codemirror.net/t/codemirror-6-0-has-been-released/4498
> We could check whether the item is already in view in the else? :+1: > Would you rather prefer not scrolling at all if the browser doesn't support scrollIntoViewIfNeeded?...
- interestingly, with rsp buttons (your codesandbox example) i can *not* reproduce in firefox anymore, but still in chrome - however, when putting links with `useLink` behind the popup, i...