Stefan Penner

Results 324 comments of Stefan Penner

> As a result, however, the worker process where the error was raised doesn't get terminated even after the Broccoli builder has been cleaned up; the parent Node process will...

Ya, with node 11 at least we won’t orphan subprocesses. If you have time to provide a reproduction or failing test, then I can be sure I am fixing the...

So, I believe: > When the tree is processed, Babel will eventually be handed an options object with an unknownOption key and will (rightfully) raise a ReferenceError. So far, no...

broccoli-babel-transpiler works around this itself: * https://github.com/babel/broccoli-babel-transpiler/blob/master/tests/utils/terminate-workers.js * https://github.com/babel/broccoli-babel-transpiler/blob/a17ae29d7a55138efb58cccf69f4c4333cc81ad0/tests/test.js#L16 * https://github.com/babel/broccoli-babel-transpiler/blob/a17ae29d7a55138efb58cccf69f4c4333cc81ad0/tests/test.js#L266

@MelSumner other then work-arounds, the root cause is in broccoli proper and most likely needs to be addressed via something such as -> https://github.com/broccolijs/broccoli/issues/479

Ya, I spiked something. I’ll try and make time to land it in a pr to show

`array.sort()` sorting overhead today is pretty hefty:

:+1: Let me know if their is something i can do to help facilitate