Stefan Karlsson comments

Results 16 comments of


                                            Stefan Karlsson

JDK-8293711: Factor out size parsing functions from arguments.cpp

> is the new version acceptable? I would have preferred if the parsing code were not placed in a .hpp file, and would have placed it in a .inline.hpp file,...

JDK-8293711: Factor out size parsing functions from arguments.cpp

> > > > is the new version acceptable? > > > > > > > > > I would have preferred if the parsing code were not placed in...

8326957: Implement JEP 474: ZGC: Generational Mode by Default

> Graal still doesn't support generational ZGC though I'm actively working on it. I'm hoping to have it in before rampdown but at least until that time JVMCI needs to...

8326957: Implement JEP 474: ZGC: Generational Mode by Default

This is my proposal: For this JEP, I propose that we stick with the current plan that -XX:+UseZGC always mean Generational ZGC. If the user try to enable the Graal...

8326957: Implement JEP 474: ZGC: Generational Mode by Default

Thanks!

8331572: Allow using OopMapCache outside of STW GC phases

Yes, ZGC code looks fine. Thanks!

8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set

> GC folk should be reviewing this not runtime. I don't fully agree with that. How these serviceability tools work, and their interfaces, are usually not something that we GC...

8301464: Code in GenFullCP is still disabled after JDK-8079697 was fixed

This is not related to GC code, could you remove the hotspot-gc label you added?

8319822: Use a linear-time algorithm for assert_different_registers()

I started to review the patch and was wondering if this could be simplify to something like this?: https://github.com/stefank/jdk/commit/f38c791793440b899ce6c4c9723470a5d4b18050 I tested this with this small section of temporary static_asserts: https://github.com/stefank/jdk/commit/30da4d6abeee14e4e4f44034295f1bb0ad2e3016...

8319822: Use a linear-time algorithm for assert_different_registers()

> > I started to review the patch and was wondering if this could be simplify to something like this?: [stefank@f38c791](https://github.com/stefank/jdk/commit/f38c791793440b899ce6c4c9723470a5d4b18050) > > Sure, it could be done. This is...