status-mobile
                                
                                 status-mobile copied to clipboard
                                
                                    status-mobile copied to clipboard
                            
                            
                            
                        fix_:sync contact request decision
fixes #19455
after the fix, the result will looks like as screenshot shows
15 Pro is device A and 15 Pro Max is device B in this screenshot. you can see that there're still differences between A and B after local pair sync.
- difference on accepted CR need more time to investigate.
- difference on declined CR is because we didn't pass CR message when invoking syncContactRequestForInstallationContact,syncContactRequestForInstallationContactwill generate AC notification withdefaultContactRequestText
however, as @cammellos said: as long as the message is the same (i.e accepted on both, declined on both), that's perfectly fine , I think the result is acceptable now.
relate status-go PR
Platforms
- Android
- iOS
status: ready
Jenkins Builds
Click to see older builds (12)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | 
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 5a98648348cbeaf686e5d0bcfada73046287e3e8 | #1 | 2024-05-08 12:02:36 | ~6 min | tests | :page_facing_up: log | 
| :heavy_check_mark: | 5a98648348cbeaf686e5d0bcfada73046287e3e8 | #1 | 2024-05-08 12:04:19 | ~7 min | android-e2e | :robot: apk:calling: | 
| :heavy_check_mark: | 5a98648348cbeaf686e5d0bcfada73046287e3e8 | #1 | 2024-05-08 12:05:17 | ~8 min | android | :robot: apk:calling: | 
| :heavy_check_mark: | 5a98648348cbeaf686e5d0bcfada73046287e3e8 | #1 | 2024-05-08 12:07:02 | ~10 min | ios | :iphone: ipa:calling: | 
| :heavy_check_mark: | 128a41e00db61b5116ea55c061382626ccec803e | #2 | 2024-05-09 02:48:45 | ~4 min | tests | :page_facing_up: log | 
| :heavy_check_mark: | 128a41e00db61b5116ea55c061382626ccec803e | #2 | 2024-05-09 02:54:20 | ~10 min | ios | :iphone: ipa:calling: | 
| :heavy_check_mark: | 128a41e00db61b5116ea55c061382626ccec803e | #2 | 2024-05-09 02:55:53 | ~11 min | android-e2e | :robot: apk:calling: | 
| :heavy_check_mark: | 128a41e00db61b5116ea55c061382626ccec803e | #2 | 2024-05-09 02:57:20 | ~13 min | android | :robot: apk:calling: | 
| :heavy_check_mark: | 430ee6ffa58b6aca75b418dc5fe7bb397d4a511a | #3 | 2024-05-09 12:53:10 | ~5 min | tests | :page_facing_up: log | 
| :heavy_check_mark: | 430ee6ffa58b6aca75b418dc5fe7bb397d4a511a | #3 | 2024-05-09 12:56:17 | ~9 min | android-e2e | :robot: apk:calling: | 
| :heavy_check_mark: | 430ee6ffa58b6aca75b418dc5fe7bb397d4a511a | #3 | 2024-05-09 12:57:19 | ~10 min | android | :robot: apk:calling: | 
| :heavy_check_mark: | 430ee6ffa58b6aca75b418dc5fe7bb397d4a511a | #3 | 2024-05-09 12:58:55 | ~11 min | ios | :iphone: ipa:calling: | 
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result | 
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 803adc3fe538ec38d907bd34985839cf3555dc9b | #4 | 2024-05-14 02:28:10 | ~6 min | android | :robot: apk:calling: | 
| :heavy_check_mark: | 803adc3fe538ec38d907bd34985839cf3555dc9b | #4 | 2024-05-14 02:28:56 | ~7 min | tests | :page_facing_up: log | 
| :heavy_check_mark: | 803adc3fe538ec38d907bd34985839cf3555dc9b | #4 | 2024-05-14 02:31:01 | ~9 min | ios | :iphone: ipa:calling: | 
| :heavy_check_mark: | 803adc3fe538ec38d907bd34985839cf3555dc9b | #4 | 2024-05-14 02:32:01 | ~10 min | android-e2e | :robot: apk:calling: | 
| :heavy_check_mark: | 43d7776848564427b204714a7d7792dca98a7ff4 | #5 | 2024-05-15 00:23:45 | ~6 min | tests | :page_facing_up: log | 
| :heavy_check_mark: | 43d7776848564427b204714a7d7792dca98a7ff4 | #5 | 2024-05-15 00:26:21 | ~8 min | android-e2e | :robot: apk:calling: | 
| :heavy_check_mark: | 43d7776848564427b204714a7d7792dca98a7ff4 | #5 | 2024-05-15 00:27:06 | ~9 min | ios | :iphone: ipa:calling: | 
| :heavy_check_mark: | 43d7776848564427b204714a7d7792dca98a7ff4 | #5 | 2024-05-15 00:27:21 | ~9 min | android | :robot: apk:calling: | 
Hi @VolodLytvynenko , this PR is ready for manual QA
77% of end-end tests have passed
Total executed tests: 52
Failed tests: 10
Expected to fail tests: 2
Passed tests: 40
IDs of failed tests: 727230,702732,704613,702851,703297,727229,703202,702807,702808,702775 
IDs of expected to fail tests: 703495,703503 
Failed tests (10)
Click to expand
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 | 
| 
  | 
| 2. test_wallet_send_eth, id: 727229 | 
| 
  | 
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 | 
| 
 
 Device 1: Device 2: | 
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 | 
| 
 
 Device 1: | 
| 2. test_links_deep_links, id: 702775 | 
| 
 
 Device 1: | 
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 | 
| 
 
 Device 1: Device 2: Device 3: | 
| 2. test_group_chat_send_image_save_and_share, id: 703297 | 
| 
 
 Device 1: Device 2: Device 3: | 
| 3. test_group_chat_reactions, id: 703202 | 
| 
 
 Device 1: Device 2: Device 3: | 
| 4. test_group_chat_join_send_text_messages_push, id: 702807 | 
| 
 
 Device 1: Device 2: Device 3: | 
| 5. test_group_chat_offline_pn, id: 702808 | 
| 
 
 Device 1: Device 2: Device 3: | 
Expected to fail tests (2)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_mute_chat, id: 703495 | 
| 
 [[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] Device 1: Device 2: Device 3: | 
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 | 
| [[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] | 
Passed tests (40)
Click to expand
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 | 
| Device sessions Device 1: Device 2: | 
| 2. test_community_hashtag_links_to_community_channels, id: 702948 | 
| Device sessions Device 1: Device 2: | 
| 3. test_community_mentions_push_notification, id: 702786 | 
| Device sessions Device 1: Device 2: | 
| 4. test_community_leave, id: 702845 | 
| Device sessions Device 1: Device 2: | 
| 5. test_community_join_when_node_owner_offline, id: 703629 | 
| Device sessions Device 1: Device 2: | 
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 | 
| Device sessions Device 1: Device 2: | 
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 | 
| Device sessions Device 1: Device 2: | 
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 | 
| Device sessions Device 1: Device 2: | 
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 | 
| Device sessions Device 1: Device 2: | 
| 3. test_1_1_chat_mute_chat, id: 703496 | 
| Device sessions Device 1: Device 2: | 
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 | 
| Device sessions Device 1: Device 2: | 
| 2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 | 
| Device sessions Device 1: Device 2: | 
| 3. test_1_1_chat_push_emoji, id: 702813 | 
| Device sessions Device 1: Device 2: | 
| 4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 | 
| Device sessions Device 1: Device 2: | 
| 5. test_1_1_chat_edit_message, id: 702855 | 
| Device sessions Device 1: Device 2: | 
| 6. test_1_1_chat_send_image_save_and_share, id: 703391 | 
| Device sessions Device 1: Device 2: | 
| 7. test_1_1_chat_pin_messages, id: 702731 | 
| Device sessions Device 1: Device 2: | 
| 8. test_1_1_chat_message_reaction, id: 702730 | 
| Device sessions Device 1: Device 2: | 
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 | 
| Device sessions Device 1: Device 2: | 
| 2. test_community_one_image_send_reply, id: 702859 | 
| Device sessions Device 1: Device 2: | 
| 3. test_community_emoji_send_copy_paste_reply, id: 702840 | 
| Device sessions Device 1: Device 2: | 
| 4. test_community_mark_all_messages_as_read, id: 703086 | 
| Device sessions Device 1: Device 2: | 
| 5. test_community_contact_block_unblock_offline, id: 702894 | 
| Device sessions Device 1: Device 2: | 
| 6. test_community_edit_delete_message_when_offline, id: 704615 | 
| Device sessions Device 1: Device 2: | 
| 7. test_community_message_delete, id: 702839 | 
| Device sessions Device 1: Device 2: | 
| 8. test_community_message_send_check_timestamps_sender_username, id: 702838 | 
| Device sessions Device 1: Device 2: | 
| 9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 | 
| Device sessions Device 1: Device 2: | 
| 10. test_community_message_edit, id: 702843 | 
| Device sessions Device 1: Device 2: | 
| 11. test_community_unread_messages_badge, id: 702841 | 
| Device sessions Device 1: Device 2: | 
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 | 
| Device sessions Device 1: | 
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 | 
| Device sessions Device 1: | 
| 3. test_community_undo_delete_message, id: 702869 | 
| Device sessions Device 1: | 
| 4. test_community_navigate_to_channel_when_relaunch, id: 702846 | 
| Device sessions Device 1: | 
| 5. test_community_mute_community_and_channel, id: 703382 | 
| Device sessions Device 1: | 
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 | 
| Device sessions Device 1: | 
| 2. test_wallet_add_remove_watch_only_account, id: 727232 | 
| Device sessions Device 1: | 
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 | 
| Device sessions Device 1: Device 2: | 
| 2. test_activity_center_contact_request_decline, id: 702850 | 
| Device sessions Device 1: Device 2: | 
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 | 
| Device sessions Device 1: Device 2: | 
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 | 
| Device sessions Device 1: Device 2: | 
40% of end-end tests have passed
Total executed tests: 10
Failed tests: 6
Expected to fail tests: 0
Passed tests: 4
IDs of failed tests: 702851,704613,727230,727229,702807,702775 
Failed tests (6)
Click to expand
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 | 
| 
 
 Device 1: | 
| 2. test_links_deep_links, id: 702775 | 
| 
 
 Device 1: | 
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 | 
| 
 
 Device 1: Device 2: | 
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_join_send_text_messages_push, id: 702807 | 
| 
 
 Device 1: Device 2: Device 3: | 
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 | 
| 
  | 
| 2. test_wallet_send_eth, id: 727229 | 
| 
  | 
Passed tests (4)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_offline_pn, id: 702808 | 
| Device sessions Device 1: Device 2: Device 3: | 
| 2. test_group_chat_pin_messages, id: 702732 | 
| Device sessions Device 1: Device 2: Device 3: | 
| 3. test_group_chat_reactions, id: 703202 | 
| Device sessions Device 1: Device 2: Device 3: | 
| 4. test_group_chat_send_image_save_and_share, id: 703297 | 
| Device sessions Device 1: Device 2: Device 3: | 
Hi @qfrank thank you for PR. No issues from my side. PR is ready to be merged
17% of end-end tests have passed
Total executed tests: 6
Failed tests: 5
Expected to fail tests: 0
Passed tests: 1
IDs of failed tests: 704613,727230,727229,702807,702775 
Failed tests (5)
Click to expand
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 | 
| 
  | 
| 2. test_wallet_send_eth, id: 727229 | 
| 
  | 
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_join_send_text_messages_push, id: 702807 | 
| 
 
 Device 1: Device 2: Device 3: | 
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 | 
| 
 
 Device 1: | 
| 2. test_links_deep_links, id: 702775 | 
| 
 
 Device 1: | 
Passed tests (1)
Click to expand
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 | 
| Device sessions Device 1: Device 2: |