status-mobile
status-mobile copied to clipboard
status-im
Use image server for all kind of images and integrate identity rings
Description
Currently the http server in status-go https://github.com/status-im/status-go/blob/develop/server/server.go is used only for identicon and image messages. We should also use it for profile pictures.
There's a branch out that also handles this case, which includes work from @qfrank: https://github.com/status-im/status-mobile/tree/feature/identity-images-http-server https://github.com/status-im/status-go/tree/feature/13334
This branch has a few changes:
- Adds an identity ring to the image
- Adds a signal when the port of the http server changes
- Serves user profile pictures
Some of the work integrating the branch has already been done here:
The important things to note when finishing integrating the branch:
- If the port of the server changes, the URL should of the image should be updated and re-fetched
- Status-go should not serve user images if the user has their settings set to not display profile pictures, only identicons should be server
- If this setting changes, pictures should be reloaded
- Dark/light theme should be likely passed as a parameter, so that the identity ring can be correctly set
- Identity ring should be toggled, as we don't want to show it in the old UI, only on the new UI
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
This issue now has a funding of 600.0 DAI attached to it.
- If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin's Discord
- $1,003,842,545.49 more funded OSS Work available on the Gitcoin Issue Explorer
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work has been started.
These users each claimed they can complete the work by 1 month from now. Please review their action plans below:
1) qfrank has been approved to start work.
i would like to try this one, thanks :)
Learn more on the Gitcoin Issue Details page.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work for 600.0 DAI (600.00 USD @ $1.0/DAI) has been submitted by:
@statussceptre please take a look at the submitted work:
- [PR](https://github.com/status-im/status-mobile/pull/13771 , https://github.com/status-im/status-go/pull/2788) by @qfrank
- Learn more on the Gitcoin Issue Details page
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin's Discord
- $1,003,846,190.57 more funded OSS Work available on the Gitcoin Issue Explorer