ccronexpr icon indicating copy to clipboard operation
ccronexpr copied to clipboard

Arduino support

Open FedeBev opened this issue 5 years ago • 1 comments

Hi there

thanks for this work! It would be great to add support for SAMD21 arduino family, like mkr nb 1500, mkr GSM 1400, mkr wifi 1010 and so on..

In my opinion the following change would be enough: https://github.com/staticlibs/ccronexpr/blob/17475e10c2053650a86b1d25a692c2c20d74c420/ccronexpr.c#L106

becomes

#elif defined(ESP8266) || defined(ESP_PLATFORM) || defined(TARGET_LIKE_MBED) || defined(__SAMD21G18A__)

I'm not sure if a change if also required here https://github.com/staticlibs/ccronexpr/blob/17475e10c2053650a86b1d25a692c2c20d74c420/ccronexpr.c#L88 but leaving that line as-is in my case seems to work.

If this if fine for you I'll be happy to submit a PR.

Thanks again!

FedeBev avatar Jun 11 '20 14:06 FedeBev

Hi, sure, more platforms are always welcome, I will happily accept a PR that passes CI checks.

staticlibs avatar Jun 12 '20 18:06 staticlibs

This project is no longer maintained, see its updated and extended fork in exander77/supertinycron repo, closing the issue to archive the repo.

staticlibs avatar Sep 10 '23 12:09 staticlibs