standardx icon indicating copy to clipboard operation
standardx copied to clipboard

Update to Standard 17

Open tagliala opened this issue 3 years ago • 3 comments

Close #41

What is the purpose of this pull request? (put an "X" next to item) Allows use of Standard Engine 15 and Standard 17

[ ] Documentation update [ ] Bug fix [x] New feature [ ] Other, please explain:

What changes did you make? (Give an overview) Simple PR

Which issue (if any) does this pull request address? #41

Is there anything you'd like reviewers to focus on? Everything, I'm not a javascript developer

tagliala avatar Apr 22 '22 17:04 tagliala

🙌 Thanks for opening this pull request! You're awesome.

welcome[bot] avatar Apr 22 '22 17:04 welcome[bot]

@feross is there something preventing to merge and publish this one?

jankapunkt avatar Jun 22 '22 06:06 jankapunkt

@jankapunkt yes, there is actually an issue with snazzy and an upstream dependency not supporting warning messages

Refs:

  • standard/eslint-config-standard#229
  • standard/snazzy#29

tagliala avatar Jun 22 '22 19:06 tagliala

Any update regarding being able to fix the block in Snazzy? I wanted to use the newest version of the eslint-config-standard-with-typescript since the latest versions of typescript aren't officially supported, but standardx cause version conflicts since the config uses Standard 17, while standardx is still stuck on 16.

xChickens avatar Apr 03 '23 19:04 xChickens

As a non javascript developer, during my brief investigation, I was not able to understand where the parsing happen, so the problem may not be in Snazzy only. Ref: https://github.com/standard/snazzy/issues/29#issue-1259644824

tagliala avatar Apr 03 '23 19:04 tagliala

Moving to eslint, thanks for all these years

tagliala avatar Dec 25 '23 10:12 tagliala