Reloader icon indicating copy to clipboard operation
Reloader copied to clipboard

[ENHANCE]Define memory request and memory limit for reloder-reloader container

Open kunj-bosamia opened this issue 1 year ago • 1 comments

It's a good practice to define memory request and limit for any resource which you deploy on your kubernetes cluster

Solution -> The raw manifest file for reloader provided in the readme file should have memory request and limits defined.

Reference to readme -> https://github.com/stakater/Reloader?tab=readme-ov-file#vanilla-manifests Raw manifest file -> https://raw.githubusercontent.com/stakater/Reloader/master/deployments/kubernetes/reloader.yaml

kunj-bosamia avatar Apr 17 '24 10:04 kunj-bosamia

@kunjbosamiaFalkonry feel free to open a PR for this, these vanilla manifests are created from helm template itself, so it can be overridden there https://github.com/stakater/Reloader/blob/master/.github/workflows/push.yaml#L206

MuneebAijaz avatar Apr 24 '24 08:04 MuneebAijaz

@MuneebAijaz can i work on this issue ?

hritesh04 avatar Jun 14 '24 19:06 hritesh04

PR for this issue -> https://github.com/stakater/Reloader/pull/692

kunj-bosamia avatar Jun 15 '24 07:06 kunj-bosamia

PR is merged closing the issue.

kunj-bosamia avatar Jun 21 '24 17:06 kunj-bosamia