Reloader icon indicating copy to clipboard operation
Reloader copied to clipboard

fix(255): push image to ghcr instead of docker hub

Open karl-johan-grahn opened this issue 3 years ago • 8 comments

Fixes https://github.com/stakater/Reloader/issues/255. This change will push the docker image to ghcr instead of docker hub to avoid rate limits, using the username of the user that initiated the workflow run and the secret that is automatically created for every workflow run.

karl-johan-grahn avatar Mar 21 '22 20:03 karl-johan-grahn

@karl-johan-grahn Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-298-3b946159

stakater-user avatar Mar 21 '22 21:03 stakater-user

@karl-johan-grahn Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-298-cb39cf1a

stakater-user avatar Mar 21 '22 21:03 stakater-user

@karl-johan-grahn Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-298-a5bb0392

stakater-user avatar Mar 21 '22 21:03 stakater-user

@karl-johan-grahn Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-298-77e2df9d

stakater-user avatar Mar 21 '22 21:03 stakater-user

@karl-johan-grahn Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-298-72ae858c

stakater-user avatar Mar 21 '22 21:03 stakater-user

Any update on this being merged?

onedr0p avatar May 06 '22 23:05 onedr0p

@karl-johan-grahn Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-298-2cca4124

stakater-user avatar Jun 14 '22 07:06 stakater-user

@rasheedamir can we get some traction on this?

onedr0p avatar Jul 20 '22 12:07 onedr0p

Any update on this?

onedr0p avatar Dec 18 '22 00:12 onedr0p

@karl-johan-grahn can you plz update so, we push to both dockerhub and ghcr?

rasheedamir avatar Jan 09 '23 19:01 rasheedamir

Given the recent dockerhub announcement of removing free team orgs, I'm wondering if the current org will be affected? And if so perhaps this could finally have a high priority?

https://github.com/docker/hub-feedback/issues/2314

onedr0p avatar Mar 15 '23 22:03 onedr0p

@MahnoorAsghar can you please take this up? The chart also needs to be updated for this as we need to update the image repo.

faizanahmad055 avatar Mar 16 '23 08:03 faizanahmad055

This should be considered a high priority unless your team is paying for Dockerhub. Can anyone take this over and see it to completion?

According to the folks at Docker, you all have less than 30 days to figure out what to do if not paying for dockerhub.

onedr0p avatar Mar 16 '23 15:03 onedr0p

It seems that the situation changed (rollback of decision) : https://github.com/docker/hub-feedback/issues/2314#issuecomment-1483471738

Whisper40 avatar Apr 03 '23 14:04 Whisper40

It would still be nice to finally have this merged, to avoid things like running into rate limits. Also, the Docker organisation seems to become less and less reliable.

nicl-dev avatar Apr 03 '23 15:04 nicl-dev

I am pretty exhausted at this point of asking for this. What is the deal, is anyone maintaining this project anymore? Should we look for alternatives?

onedr0p avatar Apr 03 '23 16:04 onedr0p

@hussnain612 Yikes! You better fix it before anyone else finds out! Build has Failed!

stakater-user avatar Apr 05 '23 06:04 stakater-user

@hussnain612 Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-298-ddbe3036

stakater-user avatar Apr 05 '23 06:04 stakater-user

@onedr0p sorry for the delay. This has been merged now.

hussnain612 avatar Apr 05 '23 07:04 hussnain612