Reloader icon indicating copy to clipboard operation
Reloader copied to clipboard

Published 20 hours ago • verified publisher icon stakater

Kustomize release has not been build for over 2 years

Open BronzeDeer opened this issue 4 years ago • 2 comments

The deployment section of the README states that "/deployments/kubernetes" can be used as kustomize base, however the referenced manifests (in /deployments/kubernetes/manifests) have not been updated since Release 77 (at this point over 2 years ago.

This breakage seems to correspond with the changes to the CI in https://github.com/stakater/Reloader/commit/58c622eb9126db3ebefc413b1ba9d7e08312dadd#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52

BronzeDeer avatar Aug 26 '21 07:08 BronzeDeer

For anyone who wants a quick fix on this problem, use vanilla manifests provided in the doc

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

bases:
  - https://raw.githubusercontent.com/stakater/Reloader/v0.0.99/deployments/kubernetes/reloader.yaml

namespace: your-namespace

we10710aa avatar Sep 16 '21 02:09 we10710aa

@talha0324 @ahmedwaleedmalik Can you please check the pipeline so it can update the /deployments/kubernetes/manifests

faizanahmad055 avatar Sep 20 '21 07:09 faizanahmad055

The PR #396 addresses this issue. The manifests that are a necessary part of the chart are being kept in the manifests directory, and are also being updated. The optional manifests are being removed, as they can be generated locally by enabling them from the values file in the helm chart. There is no reason to keep them in the manifests/ directory.

MahnoorAsghar avatar Feb 24 '23 09:02 MahnoorAsghar

Closed by #396

faizanahmad055 avatar Feb 26 '23 12:02 faizanahmad055