phpstan-dba icon indicating copy to clipboard operation
phpstan-dba copied to clipboard

Published 20 hours ago • verified publisher icon staabm

re-validate test coverage

Open staabm opened this issue 3 years ago • 3 comments

it seems since introducing pdo-pgsql we missed a bit of testcoverage

  • rule tests seem to only exist for pdo-mysql and mysqli, but non for pgsql
  • double check test-cases which use $this->markTestSkipped(...) for certain cases, to make sure we don't miss feature coverage for one of the drivers (in which it might even work already, but just not covered by tests)

staabm avatar May 23 '22 07:05 staabm

@p4veI @xPaw @marmichalski maybe thats something one of you guys are interessted in working on?

staabm avatar May 23 '22 07:05 staabm

I'll try to take a look

p4veI avatar May 26 '22 13:05 p4veI

next step would be merging testsuites of Mysqli and PDO in case the same unit is tested, e.g. SyntaxErrorInQueryMethodSubclassedRuleMysqliReflectorTest and SyntaxErrorInQueryMethodSubclassedRulePdoReflectorTest

similar to what I did in https://github.com/staabm/phpstan-dba/pull/386/

same is true for all other rule tests, where we have a Pdo* and Mysqli* variant, but testing the very same Rule-class

I would prefer a new PR per unit beeing tested

staabm avatar May 30 '22 16:05 staabm