experiments icon indicating copy to clipboard operation
experiments copied to clipboard

#14 Upgrade to angular 4

Open prakash-patel opened this issue 9 years ago • 4 comments

@sstorie please look at this PR :)

prakash-patel avatar Apr 14 '17 19:04 prakash-patel

I know I haven't accepted this PR yet, but I'm still inclear if the change to ES6 is the right thing to do, and haven't had time to really expore this. I'm sure it's frustrating to put this out there and see no apparent action, and for that I apologize. I'm working to get this validated as soon as I can.

sstorie avatar May 09 '17 19:05 sstorie

As i have mention above in comment that could explain why i have updated to es6. Let me know if this need to be change.

prakash-patel avatar May 09 '17 20:05 prakash-patel

I need to double check the existing code, but previously I think I included an es6-shim so you can compile to es5 (to support more browsers) but still access the es6 features. Is that shim missing when you hit that error?

sstorie avatar May 10 '17 13:05 sstorie

After looking package.json file i don't see es6-shim listed in it.

I install es6-shim package and change compilerOptions back to es5. I am getting below error on npm start.

node_modules/rxjs/Observable.d.ts(69,60): error TS2693: 'Promise' only refers to a type, but is being used as a value here.

npm ERR! Windows_NT 10.0.15063
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "start"
npm ERR! node v6.10.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! [email protected] start: `tsc && concurrently "tsc -w" "lite-server" `
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] start script 'tsc && concurrently "tsc -w" "lite-server" '.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular4-signalr package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc && concurrently "tsc -w" "lite-server"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular4-signalr
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular4-signalr
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\src\github\experiments\angular2-signalr\client\npm-debug.log

Once i change back to es6 it's working fine. I am not pro in angular4. I am also on my learning stage. If you can figure this out why it's not working on es5 with that package it would be great.

prakash-patel avatar May 10 '17 18:05 prakash-patel