Shane Smiskol

Results 856 comments of Shane Smiskol

Grouping this way makes much more sense, still increments of 0.005. I found from manual testing that the acceptable range is approximately also 0.005, for example 1.017 to 1.022 worked...

@adeebshihadeh I think I've gotten the dash speed factors as close as I can. The two troubles I ran into were: - on Toyota stock ACC, the dash always displays...

Hmm, this removes the ability to use the convenience blinker for lane changes, I'm not sure we want that. ![Screenshot from 2022-08-26 17-42-25](https://user-images.githubusercontent.com/25857203/187007470-48637b44-60d8-43dd-aad1-13c42286b90f.png)

Have a route with the changes? Have you made sure that the convenience blinker is one second? Nevermind about that test, looks like you switched to `update_blinker_from_stalk`

Hmm, the current command doesn't work on that car?

@adeebshihadeh want me to test this on our cars here?

Yup, I compared now + 0.2 seconds vs. the actual plan in 0.2 seconds

Well I assume so since we can't interpolate the plan to 100Hz. However I haven't confirmed that it's an issue *recently*, so if anyone doesn't do that, I'll check in...

@adeebshihadeh anything else you want to show?

@jyoung8607 want to open that PR to add the footnote to see how it looks?