JFoenix
JFoenix copied to clipboard
Remove access to internal java modules
At the moment, JFoenix requires a bunch of add-opens statements to work with Java 11 (see e.g. https://github.com/jfoenixadmin/JFoenix/issues/889#issuecomment-450744122). It would be nice if the code would be refactored in such a way that these internal modules are no longer used (and thus the open statements are no longer needed).
@tobiasdiez definitely, however I'm not sure that is possible. Open to suggestions
The easiest are probably the skin classes which moved from com.sun.javafx.scene.control.skin to the public package javafx.scene.control.skin. A few other things like behaviors are not that easy to fix and probably need some rewrite
I think automating the add-opens statements when building, would be a better solution then rewriting. Though I'm not sure that's possible at the moment :s
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is still present (although I understand that it's not easy to fix).
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
It's still an issue...
@tobiasdiez you could take a look on my new library MaterialFX, it works out of the box, no workarounds. It's still in development there are only a few controls but I'm working on it almost every day