JFoenix icon indicating copy to clipboard operation
JFoenix copied to clipboard

Remove access to internal java modules

Open tobiasdiez opened this issue 6 years ago • 8 comments

At the moment, JFoenix requires a bunch of add-opens statements to work with Java 11 (see e.g. https://github.com/jfoenixadmin/JFoenix/issues/889#issuecomment-450744122). It would be nice if the code would be refactored in such a way that these internal modules are no longer used (and thus the open statements are no longer needed).

tobiasdiez avatar Sep 17 '19 20:09 tobiasdiez

@tobiasdiez definitely, however I'm not sure that is possible. Open to suggestions

jfoenixadmin avatar Sep 18 '19 07:09 jfoenixadmin

The easiest are probably the skin classes which moved from com.sun.javafx.scene.control.skin to the public package javafx.scene.control.skin. A few other things like behaviors are not that easy to fix and probably need some rewrite

tobiasdiez avatar Sep 18 '19 08:09 tobiasdiez

I think automating the add-opens statements when building, would be a better solution then rewriting. Though I'm not sure that's possible at the moment :s

jfoenixadmin avatar Sep 20 '19 14:09 jfoenixadmin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 18 '20 15:03 stale[bot]

This issue is still present (although I understand that it's not easy to fix).

tobiasdiez avatar Mar 18 '20 15:03 tobiasdiez

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 19 '20 09:09 stale[bot]

It's still an issue...

tobiasdiez avatar Sep 19 '20 13:09 tobiasdiez

@tobiasdiez you could take a look on my new library MaterialFX, it works out of the box, no workarounds. It's still in development there are only a few controls but I'm working on it almost every day

palexdev avatar Nov 15 '20 18:11 palexdev