Spencer Russell
Spencer Russell
dup of #2205? edit: also that issue includes a workaround, namely setting `right_margin` explicitly.
Another option would be to add an explicit `LOAD_PATH`-type option to the configuration, so users can specify other places they keep packages. On the other hand it might not be...
Another minor APL character issue - the "enclose" (⊂) and "disclose" (⊃) characters don't quite align. They look fine separately, but when right next to each other you can see...
That looks lovely. Thanks for all your work on this!
We have a [time-domain implementation](https://github.com/JuliaDSP/DSP.jl/blob/0339fe2035be3ab718e35e101db798005d89d8a3/src/Filters/filt.jl#L431) as part of `filt`, as well as a heuristic for when to do time-domain or FFT. Seems like we should unify `filt` and `conv`, and...
Specifying the lags is a little more complicated when you have signals of unequal size - for `x` of length `N` and `y` of length `M` the default range for...
I don't think this would affect the performance of `xcorr`, with the default options nothing it should be equivalent to what it's currently doing, and the cost of checking a...
Yeah, maybe `centre` would be better, though then there's the `center` vs. `centre` question. The index twiddling to get `maxlags` working for FFT `xcorr` is a bit tricky, but the...
I'd love to see these filters in DSP.jl. One style comment - I think it might be nicer to have separate functions for the different filter types rather than a...
I've never used this team discussion thing, so IMO an Issue on DSP.jl or Estimation.jl is probably the best place to discuss. IMO fewer packages are easier to maintain than...