scuttlebutt-protocol-guide icon indicating copy to clipboard operation
scuttlebutt-protocol-guide copied to clipboard

Published 20 hours ago • verified publisher icon ssbc

Arguments for blobs.get

Open retog opened this issue 4 years ago • 1 comments

According to https://ssbc.github.io/scuttlebutt-protocol-guide/#fetching a valid argument for blobs.get would be

{"hash":"&KYWW5Lblhq2moFO9BJhtJ5WukFRpA7eYybOwdODTt3M=.sha256","max":5242880}

However, the reference implementation is sending

{"key":"&KYWW5Lblhq2moFO9BJhtJ5WukFRpA7eYybOwdODTt3M=.sha256","max":5242880}

see: https://github.com/ssbc/ssb-blobs/commit/c3943338d6ee8b756d75a18e7350147aa0bf212f

retog avatar Oct 02 '21 17:10 retog

Looks correct, can you provide a PR? Looks like getSlice also needs an update?

arj03 avatar Oct 03 '21 19:10 arj03