jager icon indicating copy to clipboard operation
jager copied to clipboard

Email Regex Needs some Love

Open sroberts opened this issue 11 years ago • 11 comments

"emails": [
            "W32.MyDoom@mm", 
            "[email protected]", 
            "[email protected]"
]

Needs to be better. W32.MyDoom@mm is not an email.

sroberts avatar Jul 26 '14 16:07 sroberts

How specific do we want to be with domains? Do we want to list all valid TLDs (ugh!) or just accept anything that has at least two parts in the domain segment?

krmaxwell avatar Feb 20 '15 02:02 krmaxwell

so having run into this a bunch of time I think we honestly want a full list. That's a pain, but honestly it's so much more accurate. Otherwise I get all kinds of funny outputs.

sroberts avatar Feb 20 '15 17:02 sroberts

I don't disagree - just thinking through the implications of whichever course of action (both are valid in different ways).

So we'll probably want a script that updates a TLD data file to run weekly. It's not hard at all but will be important.

krmaxwell avatar Feb 20 '15 17:02 krmaxwell

oh hey https://github.com/icann/uniaccept-python is what we need.

krmaxwell avatar Feb 24 '15 15:02 krmaxwell

I welcome your PR. :smirk:

sroberts avatar Feb 24 '15 21:02 sroberts

already working on it!

krmaxwell avatar Feb 24 '15 21:02 krmaxwell

:metal:

sroberts avatar Feb 26 '15 17:02 sroberts

This shouldn't be a function of jager per se but should be handled in utilitybelt.

krmaxwell avatar Apr 24 '15 12:04 krmaxwell

I don't know if you guys killed off this project but python-iocextract should help with most of your extraction issues https://github.com/InQuest/python-iocextract

deadbits avatar Aug 22 '18 19:08 deadbits

@deadbits I haven't, but also haven't done much with it either. I've been focused more on Cacador.

sroberts avatar Aug 26 '18 20:08 sroberts

Gotcha. In that case you have no need for our iocextract project :) looks like you have it covered. But ofc if you need to take some ideas from the project feel free to.

Great work on Cacador too. First time use today 👌

deadbits avatar Aug 28 '18 21:08 deadbits