style-analyzer icon indicating copy to clipboard operation
style-analyzer copied to clipboard

Analyzer fails after lookoutd deployment

Open smacker opened this issue 6 years ago • 6 comments

Looks like style-analyzer keeps an open connection to lookoutd. When we redeploy lookout it obviously gets broken.

gRPC reestablishes connection automatically but only after the second request to the analyzer. So the first Review/Push request after restart fails.

Please don't fix it yet. We might want to fix it in lookout-sdk (in the connection helper).

smacker avatar Dec 27 '18 13:12 smacker

~related issue: https://github.com/src-d/charts/issues/128~ My bad. It is unrelated.

zurk avatar Dec 27 '18 14:12 zurk

huh? How is it related?

smacker avatar Dec 27 '18 15:12 smacker

@smacker Is it an open connection from lookoutd to analyzer (events channel) or from analyzer to lookoutd (data service)?

vmarkovtsev avatar Jan 08 '19 13:01 vmarkovtsev

From analyzer to lookoutd (data service).

smacker avatar Jan 08 '19 14:01 smacker

Please update grpcio to the recent version in your analyzer to fix the issue. You will need to use sdk v0.3.0+ for that.

smacker avatar Jan 10 '19 12:01 smacker

ok

vmarkovtsev avatar Jan 10 '19 12:01 vmarkovtsev