PHP_CodeSniffer icon indicating copy to clipboard operation
PHP_CodeSniffer copied to clipboard

Published 20 hours ago • verified publisher icon squizlabs

Fix intersection type annotations

Open geerteltink opened this issue 5 years ago • 5 comments

This PR fixes intersection type annotations for Squiz.Commenting.FunctionComment.

Fixes #2887, #2806

geerteltink avatar Mar 29 '20 13:03 geerteltink

@VincentLanglet this is what you meant?

geerteltink avatar Mar 29 '20 13:03 geerteltink

@geerteltink could you rebase your PR? I am also running into this issue where intersection types are not inspected correctly.

digibeuk avatar Oct 15 '21 06:10 digibeuk

If it gets merged than sure, if not than I don't see a point in keeping this PR up to date for so long.

geerteltink avatar Oct 15 '21 10:10 geerteltink

If it gets merged than sure, if not than I don't see a point in keeping this PR up to date for so long.

Yes very true 😆 @VincentLanglet this PR was approved a long time ago but never merged, could you look into it again, it would be a big deal for us 👍🏻

digibeuk avatar Oct 22 '21 19:10 digibeuk

If it gets merged than sure, if not than I don't see a point in keeping this PR up to date for so long.

Yes very true 😆 @VincentLanglet this PR was approved a long time ago but never merged, could you look into it again, it would be a big deal for us 👍🏻

Im not maintainer

VincentLanglet avatar Oct 23 '21 07:10 VincentLanglet