cocoapods-generate icon indicating copy to clipboard operation
cocoapods-generate copied to clipboard

`swift_version` in the Podspec isn't reflected in the generated Xcode project(s)

Open Buzz-Lightyear opened this issue 3 years ago • 3 comments

My Pod requires Swift 5 to compile and I set it in the Podspec:

  s.swift_version = '5.0'

However, the generated Xcode project still sets the version to 4.0:

smuthu in ~/Sandbox/ios-video-player on branch master >grep 'SWIFT_VERSION = 4.0' ./ -r --color=auto -n
...
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:9874:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:9916:				SWIFT_VERSION = 4.0;
...
.//GeneratedWorkspace/Workspace/Workspace.xcodeproj/project.pbxproj:287:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Workspace.xcodeproj/project.pbxproj:374:				SWIFT_VERSION = 4.0;

I was able to run

find . -name '*.pbxproj' -print0 | xargs -0 sed -i "" "s/SWIFT_VERSION\ =\ 4.0/SWIFT_VERSION\ =\ 5.0/g"

and confirmed that my targets build correctly.

cocoapods-generate should respect the swift_version flag and reflect it in the generated Xcode projects.

Buzz-Lightyear avatar Mar 08 '22 19:03 Buzz-Lightyear

I apologize, the setting actually comes from our plugins.

Buzz-Lightyear avatar Mar 08 '22 19:03 Buzz-Lightyear

Actually, I take that back. I ran pod gen and the Swift version is definitely set to 4.0 before our plugins do anything:

smuthu in ~/Sandbox/ios-video-player on branch master >pod gen LIVideoPlayer.podspec LIVideoPlayerGoogleCastPlayback.podspec [email protected]:multiproduct/podspec-repo.git --local-sources=./ --gen-directory=GeneratedWorkspace --clean --repo-update --single-workspace --auto-open
I, [2022-03-08T11:43:35.229056 #43257]  INFO -- : Running mint dependency create-dependency-spec --overwrite to create default dependency spec

Updating specs repos
Updating spec repo `githubprivate-multiproduct-podspec-repo`

Generating workspace in `GeneratedWorkspace/Workspace`
    $ /usr/bin/open /Users/smuthu/Sandbox/ios-video-player/GeneratedWorkspace/Workspace/Workspace.xcworkspace
smuthu in ~/Sandbox/ios-video-player on branch master >grep 'SWIFT_VERSION = 4.0' ./ -r --color=auto -n
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:9856:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:9891:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:9925:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:9960:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:9994:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10029:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10064:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10100:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10170:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10206:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10241:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10277:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10312:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10348:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10383:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10419:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10454:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10490:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10793:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10829:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10863:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10898:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10933:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:10969:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:11003:				SWIFT_VERSION = 4.0;
.//GeneratedWorkspace/Workspace/Pods/Pods.xcodeproj/project.pbxproj:11038:				SWIFT_VERSION = 4.0;

Buzz-Lightyear avatar Mar 08 '22 19:03 Buzz-Lightyear