vscode-mark-jump icon indicating copy to clipboard operation
vscode-mark-jump copied to clipboard

Published 20 hours ago • verified publisher icon spywhere

Indent writer name in widget

Open Fred-Vatin opened this issue 8 years ago • 6 comments

VS Code version OS Extension version
1.13.0 Win x64 pro (french) 0.4.0

Request

It would be visually more consistent and readable with heading levels. IMHO

mark jump

The current level implementation with writer name and on line … is not ideal ↓ mark jump 2 mark jump 3

Fred-Vatin avatar Jun 13 '17 18:06 Fred-Vatin

The most possible solution would be Option 1, however as I let heading symbol to be customizable, adding padding would require another configuration in order to precisely aligned the text on both line.

For the text itself, I agree on that but the original implementation consider the usefulness of the text instead of the consistency. So, what do you think? Is it better if I always put on line ... on second line and writer on the right instead?

spywhere avatar Jun 14 '17 01:06 spywhere

Something like that 😉 mark jump

Writers name and levels 1 with white color. The rest with light grey. Just a thought.

Fred-Vatin avatar Jun 14 '17 02:06 Fred-Vatin

The second one is almost my wishlist. However, aligning on the right is not supported by current VSCode API, so I think I would go with the first one but move the line number to second line instead.

spywhere avatar Jun 20 '17 11:06 spywhere

(1) It's a bit off on very deep level though.

screen shot 2560-06-20 at 20 48 28

(2) No weird off spacing.

screen shot 2560-06-20 at 20 52 29

spywhere avatar Jun 20 '17 13:06 spywhere

I prefer the second one. Less space is better. But I would indent the writer name so it goes underneath the type, not the icon:

[ICON] [TYPE]
       [WRITER NAME]

Fred-Vatin avatar Jun 20 '17 14:06 Fred-Vatin

That's the problem though. VSCode's quick pick panel doesn't use monospace font which make the alignment of the text a bit uneasy.

spywhere avatar Jun 20 '17 14:06 spywhere