attack_range icon indicating copy to clipboard operation
attack_range copied to clipboard

Local VMs cannot be stopped

Open t0mg1t opened this issue 1 year ago • 4 comments

Hey there

When I try to stop the local attack range with python attack_range.py stop, the following error occurs:

Traceback (most recent call last): File "/home/....../git_tools/attack_range/attack_range.py", line 235, in main(sys.argv[1:]) File "/home/......./git_tools/attack_range/attack_range.py", line 231, in main return args.func(args) ^^^^^^^^^^^^^^^ File "/home/......./git_tools/attack_range/attack_range.py", line 93, in stop controller.stop(instance_ids) TypeError: VagrantController.stop() takes 1 positional argument but 2 were given

t0mg1t avatar Jan 30 '24 12:01 t0mg1t

Im just adding that i have the same problem, both stop and run commands return errors like the one described above.

roadside-picnicx avatar Mar 27 '24 15:03 roadside-picnicx

hi, goto line 93 in attack_range.py and change from controller.stop(instance_ids) to controller.stop()

TimWinkler avatar Mar 27 '24 20:03 TimWinkler

I think the issue is that if the instance_ids are "empty" it is still set to the Datatype "None" (which is not "null/empty") and then passed as 2nd argument to the VagrantController

TimWinkler avatar Mar 27 '24 20:03 TimWinkler

same issue here

rangerrkm avatar May 14 '24 21:05 rangerrkm

Thank you for reporting it. Yes it was a feature developed for the Attack Range in AWS and Azure but we forgot to add the logic to vagrant. Fix will be pushed soon.

P4T12ICK avatar Aug 13 '24 08:08 P4T12ICK