spinnaker
fix(pipelineTriggers): change buildNumber type from int to string
in order to support build numbers which are not strict integers (i.e. "123.1")
https://github.com/spinnaker/spinnaker/issues/6743
new Build(number: '2', timestamp: stamp1, building: false, result: 'SUCCESS'), new Build(number: '11', timestamp: stamp1, building: false, result: 'SUCCESS'), new Build(number: '22', timestamp: stamp2, building: false, result: 'SUCCESS'),
that we know that the build 11 and 22 are considered AFTER build 2... since it's now string vs. int...
Note, the build number ordering MAY not matter, but at one point, the igor polling system did a comparison to look for any build numbers after a given pointer. I don't think it kept ALL history, but maybe i'm wrong and it keeps all previously triggered builds?
new Build(number: '2', timestamp: stamp1, building: false, result: 'SUCCESS'), new Build(number: '11', timestamp: stamp1, building: false, result: 'SUCCESS'), new Build(number: '22', timestamp: stamp2, building: false, result: 'SUCCESS'),
that we know that the build 11 and 22 are considered AFTER build 2... since it's now string vs. int...
should we switch to order by timestamp? or convert to int in this specific case where we know the underlying system is numeric?
I'd absolutely order by timestamps as a rule vs. build numbers! As long as we can get relative timestamps. There's a LOT in this PR, so apologies i've not dug NEAR enough to make sure not missed anything, and whether my concerns are TRULY relevant.