alabaster
alabaster copied to clipboard
Added width compatibility for mobiles!
Solves #139 @bitprophet Please Review!
During the build of alabaster docs, I am facing this issue!:
Extension error:Could not import extension releases (exception: No module named releases)
So, after merging this, we can get something like this without further tweaks: https://poliastro-sh.readthedocs.io/en/doc-theme-change/
Re: #139 - can you provide some details on exactly what behavior I should be confirming is fixed here? Thanks! Offhand I don't see a huge problem with this but I'm still curious what exactly it's solving. (At this point in time I am hoping nobody would ever try loading up a Sphinx doc site on <250px display...probably? :D)
Hi! @bitprophet . Currently, if you try to view https://inb.readthedocs.io/en/latest/ in mobile, or any device less than 450px(which is a lot TBH), you have to scroll left and right to read things (Which gets quite disastrous).
I kept 250px to be on a safe side. Mobiles generally have screen size from 290px to 400 px.
See this, in which I fixed this problem. https://poliastro-sh.readthedocs.io/en/doc-theme-change This is more responsive and user friendly. :)
At this point in time I am hoping nobody would ever try loading up a Sphinx doc site on <250px display...probably? :D)
True, indeed that's why I kept it as a min device width :D
One can always put some custom CSS, but I guess responsiveness must be shipped with the theme.
I noticed this bug in all alabaster themed website using my mobile phone. @bitprophet please merge @shreyasbapat PR, thanks!
I make a PR related this! I am glad if you can see! https://github.com/bitprophet/alabaster/pull/157
Is there a reason not to merge this PR? It does solve the compatibility issue on mobile devices which is otherwise making lines overflow.