spectre.console icon indicating copy to clipboard operation
spectre.console copied to clipboard

Fix @ being used in figlet font

Open Saalvage opened this issue 3 years ago • 1 comments

Currently, @ being used in a figlet font causes it to not load, as all @ are removed from every line, which causes line length differences and is incorrect.

According to http://www.jave.de/figlet/figfont.html section "FIGcharacter Data", (which, I'm not sure is equivalent to a standard specification?) theoretically:

The FIGdriver will eliminate the last block of consecutive equal characters from each line of sub-characters when the font is read in.

.. and @ and $ are only conventions for the chosen terminating character.

However, considering @ is currently hardcoded as the only valid terminating character and the fact that it has not caused any problems thus far it is safe to assume that it is fine in practice to stick by this convention.


It might be worth considering additional fonts for the tests to potentially uncover similar issues, but that is beyond the scope of this pull request.

Saalvage avatar Sep 21 '22 04:09 Saalvage

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 21 '22 04:09 CLAassistant

Merged! Thank you for your contribution. Much appreciated! 👍

patriksvensson avatar Oct 01 '22 15:10 patriksvensson