nbsphinx icon indicating copy to clipboard operation
nbsphinx copied to clipboard

Use github actions as CI

Open s-weigand opened this issue 5 years ago • 8 comments

Last month github released github actions as CI service and the test runners are a lot more 'buffed' than the ones on travis or circleCI. Also you can run up to 20 concurrent builds, which would greatly reduce the time you need to wait for the CI results (especially on MacOs). It also supports artifact upload, which I think is the only use of the CircleCi test. If you want to change your CI service I can make a PR for that, since I'm pretty used to it by now, after transitioning most of my own projects.

s-weigand avatar Dec 06 '19 11:12 s-weigand

Yes please, that would be great!

It also supports artifact upload, which I think is the only use of the CircleCi test.

Well yes, and it also tests if the artifacts can be built in the first place, especially the PDF version.

The real point isn't artifact uploading, but the automatic hosting of the artifacts (without jumping through hoops). Can Github Actions do that, too?

mgeier avatar Dec 06 '19 12:12 mgeier

I don't fully understand the automatic hosting part :sweat_smile: The Actions themselves aren't public (you need to be logged into github to see them) for security reasons, so external resources can't access them. But you can upload artifacts in a job and download them from it as well (see).

s-weigand avatar Dec 06 '19 12:12 s-weigand

With "automatic hosting" I mean that the artifacts are provided for direct download by the Action itself, without having to upload it to some user-specified third-party server.

The upload-artifact action seems to do that, but it looks like it provides all artifacts as .zip archives, which is totally annoying. I would like to get a link to a PDF where I can click on and see the PDF, without having to download a .zip file and unpacking it.

Same for the HTML files. Getting them as .zip file would be annoying, wouldn't it?

But anyway, it would still be nice to replace Travis-CI with Github Actions!

mgeier avatar Dec 06 '19 14:12 mgeier

I see your point and there is quite a huge demand for that feature hopefully v2 will be out sometime soon, until then CircleCi seems more practical.

s-weigand avatar Dec 08 '19 23:12 s-weigand

See also #358.

mgeier avatar Dec 16 '19 18:12 mgeier

Looks like v2 will get the option to host single files, I will postpone the work on this and see how it plays out. 'mid-January' isn't far anyway 😋

s-weigand avatar Jan 09 '20 19:01 s-weigand

Just a little update: It is now possible to upload single files and whole directories without zipping them, but the Github GUI cannot yet display them properly. For now, each artifact is still provided as ZIP files.

mgeier avatar Apr 30 '20 11:04 mgeier

Thx for the info, I saw that there was an update, but I didn't yet have time to play around with it and see how it goes.

s-weigand avatar Apr 30 '20 11:04 s-weigand

I think this can be closed, any follow-up discussions can be held at #495.

mgeier avatar May 04 '24 11:05 mgeier