notebooks

notebooks copied to clipboard

This is what I see when I fire up the notebook:

p.s. This notebook is one of the three that was advertised as following style guide and yet this notebook uses HTML directly, which is not recommended per Design for portability. :woman_shrugging:

cc @ceb8

Related issue: #29

Hmm, yeah, and it looks like It's also not working on the HTML page: https://spacetelescope.github.io/notebooks/notebooks/MAST/Kepler/Kepler_Lightcurve/kepler_lightcurve.html

For a bit more context: one of the earlier templates used for some of these had a table of contents. I think that pre-dated #29 and the idea of auto-generating TOCs. So I guess the core question is: are we ok just removing the hand-generated TOCs like this? I think I am, but I think we want buy-in from authors first.

Also defensible might be to fix them to work as a temporary measure until #29 is done/#58 is in and then remove them?

@eteq Does #29 mean that when you download the notebook to use locally you loose the TOC?

@ceb8 , yes. It is not functional even locally, as I reported above.

@eteq , :+1: to remove the hand-generated HTML thingy altogether.

@pllim I meant does the auto generated TOC described in #29 work locally not the existing html TOC.

@pllim I meant does the auto generated TOC described in #29 work locally not the existing html TOC.

@ceb8

Not sure if #29 includes a local TOC but #58 uses javascript from a jupyter extension for local use. If installed it automatically generates a TOC for the notebook that is viewable within jupyter notebooks. If #58 is implemented, perhaps the notebook docs should recommend installing this extension for local use?