notebooks

notebooks copied to clipboard

As has been discussed with @eteq, @mwcraig, @kelle, this PR includes four notebooks and supplemental materials for the photutils tutorial that I had been developing on eteq/csi-stsci-notebooks. We determined it makes more sense for them to exist in this repo as we look towards future plans.

As far as I understand them, those future plans include integration with learn.astropy.org (along with the rest of spacetelescope/notebooks), and ultimately being hosted within the photutils documentation.

The four notebooks are ordinal, and cover the following topics:

• Background estimation
• Source detection
• Aperture photometry
• PSF photometry (this notebook is currently just a scaffold)

I invite anyone who is curious to review these notebooks now, though I hope to get more content into the PSF photometry notebook before merging.

Seems it ran into the same execution error on a few of the notebooks: 01_background_estimation 02_source_detection 03_aperture_photometry 04_psf_photometry

[Errno 2] No such file or directory: 'latex': 'latex'

cbar.set_label(r'Flux Count Rate ({})'.format(xdf_image.unit.to_string('latex')), 
               rotation=270, labelpad=30)
ax1.set_xlabel('X (pixels)')
ax1.set_ylabel('Y (pixels)')

I did see that... though I don't get this error when I run the notebooks locally.

Do you have any tips for what I can do to further investigate that and fix it? I am still pretty unfamiliar with exactly how the notebook HTML is compiled.

I removed the text.usetex line from the mplstyle file and it seems to have done the trick. I believe its just the circleCI linux image missing the required latex formatting resources?

If this is needed, we can try adding sudo apt-get install dvipng texlive-latex-extra texlive-fonts-recommended to the circle config to install what I believe is missing for text.usetex to work.

Here is the latest generated html after removing usetex, please look it over to see if it looks correct and the formulas are formatted as they should be. If not, I can try adding tex to the build machine.

Okay, at this point I have gone through all of @mwcraig's edits that I am capable of responding to. I'm happy to add more changes if something arises in the comments for those I was not able to respond to.

@laurenmarietta -- I've responded to the ones where I have an answer, which is not all of them 😬.

From my perspective, the remaining ones are not critical and I am 💯 on merging once the couple changes I just suggested are accepted.

Note the CI failed on the most recent one for a different notebook. The odd thing is that that seemed to work in the most recent master. I've tried restarting to see if that does the job, but if it fails again this might benefit from a rebase to get the CI to pass.

One more note on this PR: probably we want to just remove the PSF one for now since it's a scaffold. If someone decides they want to take it on they certainly can, but in the meantime a partially-done notebook doesn't really belong in this repo.

After some discussion at the 2019 Astropy Coordination Meeting, @mwcraig has volunteered to help finish out this notebook (as it dove-tails well with some of his other work building a ccd reduction guide). He will take this branch and finish it out in a separate PR.

cc @mwcraig @adrn @kelle @laurenmarietta @nmearl