spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

Published 20 hours ago • verified publisher icon spacedriveapp

Add menu item for Settings

Open maxichrome opened this issue 3 years ago • 2 comments
trafficstars

This PR adds a menu item with a standard Cmd+, shortcut, which navigates to the Settings screen in-app. This also adds macOS' native keyboard shortcut hint & handling.

A screenshot of the application menu on macOS with the Spacedrive item expanded, revealing a 'Settings...' item with a command-comma keyboard shortcut.

Closes #317

maxichrome avatar Jun 28 '22 12:06 maxichrome

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
spacedrive-landing ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 5:54AM (UTC)
spacedrive-storybook ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 5:54AM (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 5:54AM (UTC)

vercel[bot] avatar Jun 28 '22 12:06 vercel[bot]

ENG-193 Add menu item for opening Settings

Add a menu item with a cmd-comma shortcut that navigates the active window to the app's settings.

Screenshot 2022-06-28 at 07.33.16.png

linear[bot] avatar Jun 28 '22 12:06 linear[bot]

IIRC the macOS convention for this is Preferences not settings, but that's a minor detail haha

Brendonovich avatar Aug 30 '22 06:08 Brendonovich

It is Preferences in code so I think that was already fixed by @maxichrome.

oscartbeaumont avatar Aug 30 '22 06:08 oscartbeaumont