defradb

defradb copied to clipboard

Relevant issue(s)

Resolves #2508

Description

Replaces go implementation of connor package with rust implementation. All the input into connor package is serialized into JSON format understandable by rust implementation and passed across ABI boundary.

JSON was chosen just to keep things as simple as possible. We are not going keep the current state long (hopefully).

Note: We shouldn't merge this PR unless we are ready to allocate some human resources into transitioning DefraDB to Rust.

Tasks

• [x] I made sure the code is well commented, particularly hard-to-understand areas.
• [x] I made sure the repository-held documentation is changed accordingly.
• [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
• [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

Specify the platform(s) on which this was tested:

• MacOS

question: The CI is failing, are you wanting feedback before getting that to work?

Only done an quick look, nothing immediate code wise. But can you create a follow-up issue to change the null behavior for Numeric comparison on the Go connor implementation too. So that it matches the new behavior defined by the udpated tests in this PR?

Only done an quick look, nothing immediate code wise. But can you create a follow-up issue to change the null behavior for Numeric comparison on the Go connor implementation too. So that it matches the new behavior defined by the udpated tests in this PR?

I updated Go behaviour to match new expectations.