react-oauth2-pkce icon indicating copy to clipboard operation
react-oauth2-pkce copied to clipboard

Published 20 hours ago • verified publisher icon soofstad

feat: fix functions names & related terminology to be imperative

Open getsnoopy opened this issue 1 year ago • 3 comments

What does this pull request change?

This commit changes the login function to be logIn. It also updates any related terminology in the docs or otherwise to match.

Why is this pull request needed?

Function names should conventionally be in the imperative form, but the login() function didn't conform to this convention.

Issues related to this change

#115

getsnoopy avatar Mar 03 '24 04:03 getsnoopy

Thanks for the PR, I have nothing to add beyond Sebastians review. Let's fixed that, and it's ready for merge :slightly_smiling_face:

soofstad avatar Mar 16 '24 10:03 soofstad

@getsnoopy Are you able to make the requested changes?

sebastianvitterso avatar Apr 03 '24 06:04 sebastianvitterso

Yeah; just been busy with work and life. I can get to this next week.

getsnoopy avatar Apr 05 '24 02:04 getsnoopy

Apologies for the delay. I've updated the code now.

getsnoopy avatar May 10 '24 00:05 getsnoopy