cordova-plugin-opentok

cordova-plugin-opentok copied to clipboard

See https://github.com/songz/cordova-plugin-opentok/issues/119

thanks @CallanIwan, it seems like a better option would be to have a file which loads and evals the latest opentok.min.js from the server, rather than checking in one snapshot that will soon be out of date and need to be maintained. what do you think?

Yeah that sounds like the better option. The export (module.exports = window.OT;) line has to be added to the opentok js library for the browser to work.

2015-05-26 20:33 GMT+02:00 Ankur Oberoi [email protected]:

thanks @CallanIwan https://github.com/CallanIwan, it seems like a better option would be to have a file which loads and evals the latest opentok.min.js from the server, rather than checking in one snapshot that will soon be out of date and need to be maintained. what do you think?

— Reply to this email directly or view it on GitHub https://github.com/songz/cordova-plugin-opentok/pull/176#issuecomment-105627212 .

@aoberoi As you can see in the commit comments I added the requested changes and also made some minor changes to the download of IOS SDK. Unfortunately I could not use the minified version of the OpenTokJS Client. This minified version has also uglified functions and variables. I needed to add module.exports = window.OT; to the file in order to work within Cordova. If you know how to add this in the minified version I could download the minified, but from this point I don't see how.

excellent work @CallanIwan, i'm going to review it tomorrow, but I just wanted to say thanks so much.

When is tomorrow? :-)