solidus icon indicating copy to clipboard operation
solidus copied to clipboard

Published 20 hours ago • verified publisher icon solidusio

SSL on fonts.googleapis.com

Open jarednorman opened this issue 3 years ago • 4 comments

We need to use SSL to access font.googleapis.com. Requests using regular HTTP no longer work.

There are current three PRs open that cover this for the support versions (thanks @RyanofWoods!):

  • #4210
  • #4211
  • #4212

As I noted here, we may want to backport that to even more versions as this is liable to break specs on any extensions that still support older versions and run feature specs.

@Noah-Silvera has volunteered to do at least v2.9 and v2.10 which she needs for our TaxJar extension if we're happy to merge the fixes into unsupported versions.

jarednorman avatar Nov 29 '21 23:11 jarednorman

@Noah-Silvera You've got the go-ahead to PR those older versions.

jarednorman avatar Dec 01 '21 16:12 jarednorman

We won't need to release new versions of those unsupported versions, since simply merging fixes should resolve CI issues you're seeing.

jarednorman avatar Dec 01 '21 16:12 jarednorman

I already merged the one for 2.10. As I think it's the only one needed, I'm going to close it. Thanks for working on it!

waiting-for-dev avatar Dec 02 '21 05:12 waiting-for-dev

Oh, I just saw a PR for 2.9. Reopening!!

waiting-for-dev avatar Dec 02 '21 05:12 waiting-for-dev

Closing, we are not supporting 2.9 anymore.

kennyadsl avatar Sep 02 '22 09:09 kennyadsl