Simon Hengel

Results 312 comments of Simon Hengel

> I don't view that spike at the end as particularly significant Hmm, with spike I was really only referring to the spike in stack usage towards the end (the...

> Regarding (1), that seems reasonable to me to accept. PRs welcome.

On the one hand I like this idea, on the other hand what ever we do here has to, at least in principal, also work for other build tools (specifically...

`defaults` aren't widely used yet. Before doing anything here, I would want to see `defaults` more widely used first. I'm closing this for now, but open to discuss it again...

> `defaults.local` works, but since the local packages can live at any level of nesting (see https://github.com/nammayatri/nammayatri), you are going to have to specify a different value for all the...

> Allow `hpack --defaults-from=`, so `package.yaml` file need not be modified. I am not ready to explicitly support defaults from the command line just yet. However, GitHub defaults are cached...

@srid also keep in mind that defaults are somewhat limited, e.g. a top level `defaults` statement can only define top level fields, not per-section fields. If you run into limitations...

> I was wondering: if a package is a 'unit of distribution', and a package includes its own specification, then is a package specification that relies on information outside of...

This should already work, except for that the base directory is not configurable yet (actually it kind of is, you could change it by setting `HOME`, I guess).

@mpilgrem thanks a lot for the review. This is not going to land for now. I updated the PR description.