iglu-central icon indicating copy to clipboard operation
iglu-central copied to clipboard

Increase mkt_clickid character limit to 255

Open dumkydewilde opened this issue 2 years ago • 5 comments

As mentioned in #1311, some of Meta's fbclid parameter values are over 128 characters, causing the events to fail when this parameter is added in the campaign attribution enrichment. This PR increases the character limit from 128 to 255.

dumkydewilde avatar Jul 03 '23 10:07 dumkydewilde

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

snowplowcla avatar Jul 03 '23 10:07 snowplowcla

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

I've signed the CLA 👍

dumkydewilde avatar Jul 03 '23 10:07 dumkydewilde

Confirmed! @dumkydewilde has signed the Contributor License Agreement. Thanks so much.

snowplowcla avatar Jul 03 '23 10:07 snowplowcla

Thanks @dumkydewilde - we're looking at this at the moment, it may involve bumping this even higher due to some ad networks (e.g., Tiktok) having longer than 255 characters for their ad ids.

miike avatar Jul 19 '23 05:07 miike

I believe this is more complicated, because the atomic schema is hardcoded in a few places. Currently, you can disable the check as a workaround: https://docs.snowplow.io/docs/pipeline-components-and-applications/enrichment-components/configuration-reference/#enriched-events-validation-against-atomic-schema

stanch avatar Jul 21 '23 17:07 stanch