snowflake-connector-python icon indicating copy to clipboard operation
snowflake-connector-python copied to clipboard

Published 20 hours ago • verified publisher icon snowflakedb

stop escaping non-string values

Open chamini2 opened this issue 3 years ago • 3 comments

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #858

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am modifying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modifying OCSP code
    • [ ] I am adding a new dependency

  3. Please describe how your code solves the related issue.

    String escaping is being applied to non-string values.

chamini2 avatar Jul 28 '22 22:07 chamini2

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Jul 28 '22 22:07 github-actions[bot]

I am not certain if the approach on #859 is maybe the proper one.

chamini2 avatar Jul 28 '22 22:07 chamini2

I have read the CLA Document and I hereby sign the CLA

chamini2 avatar Jul 28 '22 22:07 chamini2