slurp icon indicating copy to clipboard operation
slurp copied to clipboard

added a lite option to remove content

Open Dxuian opened this issue 1 year ago • 1 comments

in reference to #2393 added a discard content boolean option

Dxuian avatar Oct 04 '24 17:10 Dxuian

Hey, John need to take a look and review your merge request. He will it soon but not today.

Thank you so much for your contribute. Feel free to improve it as much as you can. John is a special man.

BaseMax avatar Oct 04 '24 17:10 BaseMax

Hi there, happy to see you are helping to the project. It's great.

You need to do some changes, then we can approve and merge your changes.

You needs to remove "content" from the results array. you has the test for the "lite" version. Lite version does not include content. It is not the best approach but helps and we can modify later. Can you please results array needs no content for the lite version?

BaseMax avatar Oct 06 '24 09:10 BaseMax

Hi there, happy to see you are helping to the project. It's great.

You need to do some changes, then we can approve and merge your changes.

You needs to remove "content" from the results array. you has the test for the "lite" version. Lite version does not include content. It is not the best approach but helps and we can modify later. Can you please results array needs no content for the lite version?

as asked ive removed content from the new code and enhanced the old code please review and merge 🙏🙏🙏

Dxuian avatar Oct 06 '24 12:10 Dxuian

Thanks.

BaseMax avatar Oct 06 '24 13:10 BaseMax

@jbampton please merge and close🙏🙏🙏

Dxuian avatar Oct 06 '24 13:10 Dxuian

Thanks and well done.

I tested locally and it seems to work fine.

Ready for approval and then merge

On Sun, 6 Oct 2024 at 23:27, Dxuian @.***> wrote:

@jbampton https://github.com/jbampton please review and merge 🙏🙏🙏

— Reply to this email directly, view it on GitHub https://github.com/slurpcode/slurp/pull/2785#issuecomment-2395440627, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3LEGW2UWIO7RD73XMRMIDZ2E3FDAVCNFSM6AAAAABPMKI2ZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGQ2DANRSG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

johnbampton avatar Oct 06 '24 14:10 johnbampton

Many thanks and well done

BaseMax avatar Oct 06 '24 15:10 BaseMax